[rabbitmq-discuss] Pika connection negotiation behavior

Fri Mar 15 10:48:44 GMT 2013

Well, the max(client, server) behaviour is also what our clients do so 
the precedent is there. But ultimately the server will accept whatever 
the client asks for.

Cheers, Simon

On 15/03/13 06:03, Gavin M. Roy wrote:
> In Pika, currently and pre-dating my involvement, when tuning the
> connection, it uses the /*minimum*/ value above 0 that either the server
> or client provides for the heartbeat interval:
>
> https://github.com/pika/pika/blob/v0.5/pika/connection.py#L359
> https://github.com/pika/pika/blob/v0.5/pika/connection.py#L411
>
> Since introducing a heartbeat interval sent by the server of 600, this
> has set a */maximum/* heartbeat interval of 600 regardless of what the
> client sets upon creation.
>
> In reading the 0.9.1 spec, I did not see anything dictating any behavior
> of this sort for heartbeat interval negotiation.
>
> I'm inclined to allow the client to always overwrite the server, but
> since this behavior both pre-dates my involvement and is clearly
> intentional, I wanted to get some feedback before making the change.
>
> I currently have an open ticket tied to this that I would like to
> resolve before releasing 0.9.10: https://github.com/pika/pika/issues/303
>
> So, any thoughts?
>
> Gavin
>
>
>
> _______________________________________________
> rabbitmq-discuss mailing list
> rabbitmq-discuss at lists.rabbitmq.com
> https://lists.rabbitmq.com/cgi-bin/mailman/listinfo/rabbitmq-discuss
>

-- 
Simon MacMullen
RabbitMQ, VMware