[rabbitmq-discuss] Small suggestion for 1.3 scripts

[Alexis Richardson]

Thanks Holger.

We looked at APL but it just doesn't have the clarity of expression
that Fortran provides ;-)


On Tue, Apr 1, 2008 at 8:35 AM, Holger Hoffstätte <holger at wizards.de> wrote:
> Guys,
>
>  Congrats on the 1.3 release - much improved and easier installation. Here
>  are two small suggestions for the Windows scripts. I noticed that the logs
>  & db are placed in %HOMEDRIVE%\%HOMEPATH%\rabbitmq. Windows convention is
>  to use a subdirectory under the per-user %APPDATA% directory, i.e. change
>  the definition of RABBITMQ_BASE in rabbitmq-server.bat and
>  rabbitmq-multi.bat like this:
>
>  set RABBITMQ_BASE=%APPDATA%\RabbitMQ
>
>  The APPDATA path usually contains spaces ("Application Data") but I
>  confirmed that everything still works fine.
>
>  Also, since that directory might be on a user's "network profile" (getting
>  synced back and forth) it might be useful to only set the default if it
>  has not been set already, for example when the db is supposed to be shared:
>
>  if "%RABBITMQ_BASE%"=="" (
>      set RABBITMQ_BASE=%APPDATA%\RabbitMQ
>  )
>
>  Both changes are attached as patches.
>
>  Looking forward to that Fortran rewrite! (why not APL?)
>
>  Holger
>
> --- rabbitmq_server-1.3.0\sbin\rabbitmq-multi.bat       2008-04-01 11:12:20.000000000 +0200
>  +++ RabbitMQ\sbin\rabbitmq-multi.bat    2008-04-01 17:14:03.515375000 +0200
>  @@ -24,7 +24,9 @@
>   REM   Contributor(s): ______________________________________.
>   REM
>
>  -set RABBITMQ_BASE=%HOMEDRIVE%%HOMEPATH%\rabbitmq
>  +if "%RABBITMQ_BASE%"=="" (
>  +    set RABBITMQ_BASE=%APPDATA%\RabbitMQ
>  +)
>
>   set PIDS_FILE=%RABBITMQ_BASE%\rabbitmq.pids
>   set SCRIPT_HOME=.
>
> --- rabbitmq_server-1.3.0\sbin\rabbitmq-server.bat      2008-04-01 11:12:20.000000000 +0200
>  +++ RabbitMQ\sbin\rabbitmq-server.bat   2008-04-01 17:30:57.754875000 +0200
>  @@ -24,7 +24,9 @@
>   REM   Contributor(s): ______________________________________.
>   REM
>
>  -set RABBITMQ_BASE=%HOMEDRIVE%%HOMEPATH%\rabbitmq
>  +if "%RABBITMQ_BASE%"=="" (
>  +    set RABBITMQ_BASE=%APPDATA%\RabbitMQ
>  +)
>
>   if "%NODENAME%"=="" (
>      set NODENAME=rabbit
>
> _______________________________________________
>  rabbitmq-discuss mailing list
>  rabbitmq-discuss at lists.rabbitmq.com
>  http://lists.rabbitmq.com/cgi-bin/mailman/listinfo/rabbitmq-discuss
>
>



-- 
Alexis Richardson
+44 20 7617 7339 (UK)
+44 77 9865 2911 (cell)
+1 650 206 2517 (US)