[rabbitmq-discuss] RabbitMQ's WebSocket broken

[Petri Luojus]

https://chromiumcodereview.appspot.com/22375002/diff/9001/Source/modules/websockets/WebSocketHandshake.cppline
540->

By looking at the diff for the change, at least Chrome should accept the
connections when the protocol header is present. If I interpret the code
correctly, the change was made to a check to the situation where protocol
header is set on the request, but the response did not have
Web-Socket-Protocol header present.

Current source code for the module (
https://chromium.googlesource.com/chromium/blink/+/master/Source/modules/websockets/WebSocketHandshake.cpp)
indicates that the connections are accepted when the header is present and
it accompanies the same protocol version, which was requested.

So I think, this should not present problems with older Chromium-based
browsers. I don't know about Opera/Firefox/Safari/x, but I hope they have
implemented the protocol selection procedure as defined by the
specification.



On Fri, Oct 11, 2013 at 11:22 AM, Michael Klishin <michael at rabbitmq.com>wrote:

>
> On Oct 11, 2013, at 10:58 AM, Petri Luojus <luojus at gmail.com> wrote:
>
> > Could you guys look into this issue?
>
> Petri,
>
> Will adjusting Rabbit to the way new Chrome versions work somehow affect
> older browsers? (I'm not a WebSockets expert, as you can tell).
>
> MK
>
>
>
>


-- 
Petri Luojus
+358 41 437 3592
Oulu, Finland
luojus at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rabbitmq.com/pipermail/rabbitmq-discuss/attachments/20131011/bc96c2dc/attachment.htm>