<div dir="ltr"><a href="https://chromiumcodereview.appspot.com/22375002/diff/9001/Source/modules/websockets/WebSocketHandshake.cpp">https://chromiumcodereview.appspot.com/22375002/diff/9001/Source/modules/websockets/WebSocketHandshake.cpp</a> line 540-><div>
<br></div><div>By looking at the diff for the change, at least Chrome should accept the connections when the protocol header is present. If I interpret the code correctly, the change was made to a check to the situation where protocol header is set on the request, but the response did not have Web-Socket-Protocol header present.</div>
<div><br></div><div>Current source code for the module (<a href="https://chromium.googlesource.com/chromium/blink/+/master/Source/modules/websockets/WebSocketHandshake.cpp">https://chromium.googlesource.com/chromium/blink/+/master/Source/modules/websockets/WebSocketHandshake.cpp</a>) indicates that the connections are accepted when the header is present and it accompanies the same protocol version, which was requested.</div>
<div><br></div><div>So I think, this should not present problems with older Chromium-based browsers. I don't know about Opera/Firefox/Safari/x, but I hope they have implemented the protocol selection procedure as defined by the specification.</div>
<div><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Oct 11, 2013 at 11:22 AM, Michael Klishin <span dir="ltr"><<a href="mailto:michael@rabbitmq.com" target="_blank">michael@rabbitmq.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
On Oct 11, 2013, at 10:58 AM, Petri Luojus <<a href="mailto:luojus@gmail.com">luojus@gmail.com</a>> wrote:<br>
<br>
> Could you guys look into this issue?<br>
<br>
Petri,<br>
<br>
Will adjusting Rabbit to the way new Chrome versions work somehow affect<br>
older browsers? (I'm not a WebSockets expert, as you can tell).<br>
<span class="HOEnZb"><font color="#888888"><br>
MK<br>
<br>
<br>
<br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br>Petri Luojus<br>+358 41 437 3592<br>Oulu, Finland<br><a href="mailto:luojus@gmail.com" target="_blank">luojus@gmail.com</a><br><br>
</div>