[rabbitmq-discuss] .NET client SimpleRpcServer question

[Matthias Radestock]

Ryan,

Ryan Davis wrote:
> I solved this problem my adding some explicit locks in Subscription and 
> SimpleRpcServer.

Thanks for the patch. If you don't mind, we'll look into this in a few 
weeks when the person who wrote the original code is back from holidays.

Some locking is most certainly required if you are going to call Close 
from a separate thread. So the question is whether we should cater for 
this in the first place (based on your findings I am pretty sure we need 
to), and if so whether the locks are in the right place.

On the latter point, the locks look a bit too coarse-grained to me, 
covering activities that can take an indeterminate amount of time, such 
as interactions with the server. That may be unavoidable, but without 
understanding every single detail of the code it's hard to be sure.


Regards,

Matthias.