[rabbitmq-discuss] Rabbit Boot Steps

Wed Jun 22 11:32:20 BST 2011

Hi Alvaro,

On Sun, Jun 19, 2011 at 11:46:04PM +0200, Alvaro Videla wrote:
> I've extracted the boot steps logic into its own module. I think in
> this way it might get easier to use by projects outside RabbitMQ.
> 
> So far it depends on rabbit_misc:all_module_attributes/1 and
> rabbit_misc:build_acyclic_graph/3 but they are used in other parts of
> Rabbit's code so I don't know what's the best approach here.
> 
> I've added some specs, I hope they are correct, since is the first
> time I write those. Also I added extra functionality. So it's possible
> to have boot steps like -my_app_boot_step and so on. In this way, the
> prefix can be customized. There's a function boot_steps/1 that will
> look for the <prefix>_boot_step attributes. If prefix is omitted, then
> the current application name will be used.
> 
> My idea is to extract this module to some library via a Make target in
> the same way rabbit_common is extracted today.
> 
> I've attached the patch and the new module, let me know what you
> think.

Many thanks for your efforts.

Because the functionality is now completely non rabbit-specific, they
should not really be in a module with a rabbit_ prefix. The more
reusable parts of rabbit's code base tend to follow this rule.

We'd probably need you to sign a contributor agreement to accept these
changes, which I'll send to you off list - I don't think you've already
signed one.

Matthew