<div dir="ltr"><div>Another comment on basicPublish failures:</div><div><br></div>It would be great if the AlreadyClosedException that results from the first failed basicPublish gave a helpful shutdown reason such as channel.close, reply-code 404. As it is, there's not always a way to determine why the channel was closed without waiting for the ShutdownListener to be called (which could be later). This is crucial as it prevents me from knowing whether the basicPublish is something that should result in me recovering the channel and retrying the publish, or not.<div>
<br></div><div>- jonathan</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Oct 21, 2013 at 1:26 PM, Jonathan Halterman <span dir="ltr"><<a href="mailto:jhalterman@gmail.com" target="_blank">jhalterman@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Yea, racy indeed. I actually don't think we need to wait on a ShutdownListener since the basicPublish will eventually fail with AlreadyClosedException. That's fine as long as the Connection isn't shutdown as a result, which Steve mentioned in another thread (AlreadyClosedException always sets hardError...) is what should happen but which I haven't seen. Since I don't really have a fair chance to know that the Channel has been closed before getting an AlreadyClosedException, ideally the Connection wouldn't be closed as a result.<span class="HOEnZb"><font color="#888888"><br>
<div><br></div><div>- jonathan</div></font></span></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Oct 21, 2013 at 12:25 PM, Matthias Radestock <span dir="ltr"><<a href="mailto:matthias@rabbitmq.com" target="_blank">matthias@rabbitmq.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>On 21/10/13 20:20, Jonathan Halterman wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I'm guessing I have to<br>
fallback to Channel.isOpen or wait for the ShutdownListener to be called?<br>
</blockquote>
<br></div>
That's racy. How long would you wait?<br>
<br>
The reason that basicPublish doesn't return an error is because doing so would require waiting for a response from the server, thus making basicPublish synchronous and destroying performance.<span><font color="#888888"><br>
<br>
Matthias.</font></span><div><div><br>
______________________________<u></u>_________________<br>
rabbitmq-discuss mailing list<br>
<a href="mailto:rabbitmq-discuss@lists.rabbitmq.com" target="_blank">rabbitmq-discuss@lists.<u></u>rabbitmq.com</a><br>
<a href="https://lists.rabbitmq.com/cgi-bin/mailman/listinfo/rabbitmq-discuss" target="_blank">https://lists.rabbitmq.com/<u></u>cgi-bin/mailman/listinfo/<u></u>rabbitmq-discuss</a><br>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>