<div dir="ltr">Hey Tim,<div><br></div><div style>I'm just kicking the tyres of your lager plugin with my rabbit umbrella.</div><div style><br></div><div style>Admittedly, I'm not an umbrella makefile jedi, so I just cloned your repo into a subdir of my umbrella (maybe this was the mistake). Running make results in the following issue:</div>
<div style><br></div><div style><div>[elided] generate deps</div><div>[elided] fix test deps</div><div>sed -e 's|build/<a href="http://deps.mk">deps.mk</a>|$(DEPS_FILE)|' build/<a href="http://deps.mk">deps.mk</a> > build/deps.mk.tmp && mv build/deps.mk.tmp build/<a href="http://deps.mk">deps.mk</a></div>
<div>rm -rf ./rabbitmq-lager-git</div><div>git clone <a href="http://github.com/basho/lager.git">http://github.com/basho/lager.git</a> ./rabbitmq-lager-git</div><div>Cloning into './rabbitmq-lager-git'...</div><div>
remote: Counting objects: 1822, done.</div><div>remote: Compressing objects: 100% (576/576), done.</div><div>remote: Total 1822 (delta 1330), reused 1709 (delta 1224)</div><div>Receiving objects: 100% (1822/1822), 713.54 KiB | 137 KiB/s, done.</div>
<div>Resolving deltas: 100% (1330/1330), done.</div><div># Work around weird github breakage (bug 25264)</div><div>cd ./rabbitmq-lager-git && git pull</div><div>Already up-to-date.</div><div>cd ./rabbitmq-lager-git && git checkout 9719370eeaf8b64c1c3e79fb7052cb1ca29f16c8</div>
<div>Note: checking out '9719370eeaf8b64c1c3e79fb7052cb1ca29f16c8'.</div><div><br></div><div>You are in 'detached HEAD' state. You can look around, make experimental</div><div>changes and commit them, and you can discard any commits you make in this</div>
<div>state without impacting any branches by performing another checkout.</div><div><br></div><div>If you want to create a new branch to retain commits you create, you may</div><div>do so (now or later) by using -b with the checkout command again. Example:</div>
<div><br></div><div>� git checkout -b new_branch_name</div><div><br></div><div>HEAD is now at 9719370... Merge pull request #120 from basho/adt-msg-has-datetime</div><div>touch rabbitmq-lager-git/.done</div><div>echo UPSTREAM_SHORT_HASH:=`git --git-dir=./rabbitmq-lager-git/.git log -n 1 HEAD | grep commit | cut -b 8-14` ><a href="http://hash.mk">hash.mk</a></div>
<div>sed -n -e 's|^.*{vsn, *"\([^"]*\)".*$|ORIGINAL_VERSION:=\1|p' <rabbitmq-lager-git/src/lager.app.src >build/<a href="http://version.mk">version.mk</a></div><div>[elided] generate deps</div>
<div>/bin/sh: escript: command not found</div><div>rm -rf build/dep-ezs</div><div>mkdir -p build/dep-ezs</div><div>[elided] copy dependent ezs</div><div>touch build/dep-ezs/.done</div><div>rm -rf build/dep-apps</div><div>
mkdir -p build/dep-apps</div><div>[elided] unzip ezs</div><div>touch build/dep-apps/.done</div><div>make: *** No rule to make target `build/<a href="http://deps.mk">deps.mk</a>', needed by `ebin/error_logger_lager_h.beam'. �Stop.</div>
</div><div style><br></div><div style>Should I maybe have created a my own subdir that points to your repo by setting the�UPSTREAM_GIT variable?</div><div style><br></div><div style>Cheers,</div><div style><br></div><div style>
Ben</div><div style><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Mar 27, 2013 at 10:03 AM, Tim Watson <span dir="ltr"><<a href="mailto:tim@rabbitmq.com" target="_blank">tim@rabbitmq.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">If anyone wants to try this plugin out, there are instructions in the README file on github now. You'll need at least R14B03 to use lager afaict. Please shout if you run into any difficulties.<br>
<br>
Cheers,<br>
Tim<br>
<div class="HOEnZb"><div class="h5"><br>
On 27 Mar 2013, at 00:19, Ben Hood wrote:<br>
<br>
> On Tuesday, 26 March 2013 at 15:53, Tim Watson wrote:<br>
>> I have set up an experimental repository at <a href="https://github.com/hyperthunk/rabbitmq-lager" target="_blank">https://github.com/hyperthunk/rabbitmq-lager</a> that supports logging to lager via its built in error_logger redirection. You enable via `rabbitmq-plugins enable lager` and configure it in the RabbitMQ config file just like any other plugin, under the key 'lager'. In the morning I'll chat with the guys about integrating this as experimental plugin for the time being, so people can play around and see if it offers the required functionality.<br>
> Very cool - nice one Tim!<br>
</div></div><div class="HOEnZb"><div class="h5">> _______________________________________________<br>
> rabbitmq-discuss mailing list<br>
> <a href="mailto:rabbitmq-discuss@lists.rabbitmq.com">rabbitmq-discuss@lists.rabbitmq.com</a><br>
> <a href="https://lists.rabbitmq.com/cgi-bin/mailman/listinfo/rabbitmq-discuss" target="_blank">https://lists.rabbitmq.com/cgi-bin/mailman/listinfo/rabbitmq-discuss</a><br>
<br>
_______________________________________________<br>
rabbitmq-discuss mailing list<br>
<a href="mailto:rabbitmq-discuss@lists.rabbitmq.com">rabbitmq-discuss@lists.rabbitmq.com</a><br>
<a href="https://lists.rabbitmq.com/cgi-bin/mailman/listinfo/rabbitmq-discuss" target="_blank">https://lists.rabbitmq.com/cgi-bin/mailman/listinfo/rabbitmq-discuss</a><br>
</div></div></blockquote></div><br></div>