<div class="gmail_extra"><br><div class="gmail_quote">On Wed, Oct 31, 2012 at 5:03 PM, Peter Friend <span dir="ltr"><<a href="mailto:pfriend@gehrytech.com" target="_blank">pfriend@gehrytech.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div lang="EN-US" link="blue" vlink="purple"><p class="">
<span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">Here are the issues I've had so far with 0.9.6:<u></u><u></u></span></p>
<p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><u></u> 1</span><span style="color:rgb(31,73,125);font-family:Calibri,sans-serif;font-size:11pt">. exchange_declare() type arg is now exchange_type</span></p>
</div></blockquote><div><br></div><div>Gotcha, I had moved way from the auto-assignment of reserved keywords. type, in this case is a reserved word in Python, using it would reassign the type function to the value passed in. While this does break with 0.9.5, it does seem like it's the right behavior. Thoughts?</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div lang="EN-US" link="blue" vlink="purple"><div><p class="">
<span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><u></u><u></u></span></p><p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)">2. Ran into problems with RPC type calls. In 0.9.5 the docs for channel has:<u></u><u></u></span></p>
<p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"> queue_declare(self, callback=None, ticket=0, queue='', passive=False, durable=False, exclusive=False, auto_delete=False, nowait=False, arguments={})</span></p>
</div></div></blockquote><div><br></div><div>ticket has been removed from all the calls since it is deprecated in the protocol and not used by anything. I can see how the behavioral change can cause an issue if you were putting it in by default.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div lang="EN-US" link="blue" vlink="purple">
<div>
<p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><u></u><u></u></span></p><p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"> and in 0.9.6:<u></u><u></u></span></p>
<p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"> queue_declare(self, callback, queue, passive=False, durable=False, exclusive=False, auto_delete=False, nowait=False, arguments=None)</span> </p>
</div></div></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div lang="EN-US" link="blue" vlink="purple">
<p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"><u></u><u></u></span></p><p class=""><span style="color:rgb(31,73,125);font-family:Calibri,sans-serif;font-size:11pt"> The callback and queue args are required now so a line that used to be:</span><br>
</p><p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"> result = channel.queue_declare(exclusive=True, auto_delete=True) should presumably now be:<u></u><u></u></span></p>
<p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"> result = channel.queue_declare(callback=None, queue='', exclusive=True, auto_delete=True)<u></u><u></u></span></p>
<p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"> However that results in this error:<u></u><u></u></span></p><p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"> TypeError: queue_declare() got an unexpected keyword argument 'callback'</span></p>
</div></blockquote><div>Yeah callbacks in BlockingConnection were removed for synchronous commands. </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple"><p class=""><span style="font-size:11pt;font-family:Calibri,sans-serif;color:rgb(31,73,125)"> This is confusing if you are reading the docs for channel, and is a behavior change from 0.9.5.</span></p>
</div></blockquote><div>Fair enough, in the async, I see the callback should be None, but queue should not. Any suggestions for the right behavior here? I could throw an exception for passing in an empty queue name. </div>
</div>
</div>