Thanks very much - looking forward to it. (By the way, I just created a fresh bz account with my gmail address (without the +rabbitmq) - would you mind adding it to the bug's ACL?)<br><br>Regards,<br> Tony<br><br><div class="gmail_quote">
On 27 February 2012 05:56, Steve Powell <span dir="ltr"><<a href="mailto:steve@rabbitmq.com" target="_blank">steve@rabbitmq.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Tony,<br>
<br>
Read your patch, and prefer this solution to adding extra headers.<br>
<br>
I'm raising a bug (24763) to fix our spec-compliance problem (thank you for<br>
pointing this out), and see if we can get this change in.<br>
<br>
Steve Powell<br>
<a href="mailto:steve@rabbitmq.com" target="_blank">steve@rabbitmq.com</a><br>
[wrk: <a href="tel:%2B44-2380-111-528" value="+442380111528" target="_blank">+44-2380-111-528</a>] [mob: <a href="tel:%2B44-7815-838-558" value="+447815838558" target="_blank">+44-7815-838-558</a>]<br>
<div><div><br>
On 20 Feb 2012, at 20:36, Tony Garnock-Jones wrote:<br>
<br>
> Hi Steve,<br>
><br>
> How about the attached patch? It attempts to bring the "destination"<br>
> header in MESSAGEs in to line with the STOMP 1.1 spec. I've paid<br>
> cursory attention to binary-and-slash-escaping issues but it could use<br>
> a second glance before being committed, I reckon.<br>
><br>
> Regards,<br>
> Tony<br>
><br>
> On 20 February 2012 14:56, Tony Garnock-Jones<br>
> <<a href="mailto:tonygarnockjones%2Brabbitmq@gmail.com" target="_blank">tonygarnockjones+rabbitmq@gmail.com</a>> wrote:<br>
>> Adding the routing_key puts the final small missing piece in place. A<br>
>> perhaps more STOMPish way of giving it would be to have a "to" header<br>
>> or similar carried in a MESSAGE, containing the full destination given<br>
>> in the SEND. Oh wait! I've just checked, and actually that's what's<br>
>> required by the 1.1 spec already. So the STOMP adapter isn't quite<br>
>> spec-compliant, in that it's giving the destination from the<br>
>> *subscribe* rather than the *send*.<br>
> --<br>
> Tony Garnock-Jones<br>
> <a href="mailto:tonygarnockjones@gmail.com" target="_blank">tonygarnockjones@gmail.com</a><br>
> <a href="http://homepages.kcbbs.gen.nz/tonyg/" target="_blank">http://homepages.kcbbs.gen.nz/tonyg/</a><br>
</div></div>> <better-destination-patch.patch><br>
<br>
</blockquote></div><br><br clear="all"><br>-- <br>Tony Garnock-Jones<br><a href="mailto:tonygarnockjones@gmail.com" target="_blank">tonygarnockjones@gmail.com</a><br><a href="http://homepages.kcbbs.gen.nz/tonyg/" target="_blank">http://homepages.kcbbs.gen.nz/tonyg/</a><br>