Thanks, first two points should be done.<div><br></div><div>Now it tries to read from ~/.rabbitmqadmin.conf if node is specified and the config file is not passed.</div><div><br></div><div>I am going to look at bash completion soon.</div>
<div><br></div><div>Cheers,<br clear="all">---<br>Massimo Paladin<br><br>email: <a href="mailto:massimo.paladin@gmail.com" target="_blank">massimo.paladin@gmail.com</a><br>website: <a href="http://www.mpaladin.com/" target="_blank">http://www.mpaladin.com</a><br>
flickr's page: <a href="http://flickr.com/photos/massimop" target="_blank">http://flickr.com/photos/massimop</a><br>
<br><br><div class="gmail_quote">On Thu, Feb 9, 2012 at 4:01 PM, Simon MacMullen <span dir="ltr"><<a href="mailto:simon@rabbitmq.com">simon@rabbitmq.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">On 06/02/12 17:09, Massimo Paladin wrote:<br>
</div><div class="im"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
it would be nice to see it in the next release.<br>
</blockquote>
<br></div>
OK, in that case you're lucky enough to get some code review notes :-)<br>
<br>
* Defaults seem to be broken if the configuration file is not used<br>
<br>
* It would probably make sense to look for the config file in a standard location if "-c" is not specified, e.g. ~/.rabbitmqadmin.conf<br>
<br>
* For extra credit: make the bash completion script complete "-N" from the config file...<div class="im"><br>
<br>
Cheers, Simon<br>
<br>
-- <br>
Simon MacMullen<br>
RabbitMQ, VMware<br></div>
______________________________<u></u>_________________<br>
rabbitmq-discuss mailing list<br>
<a href="mailto:rabbitmq-discuss@lists.rabbitmq.com" target="_blank">rabbitmq-discuss@lists.<u></u>rabbitmq.com</a><br>
<a href="https://lists.rabbitmq.com/cgi-bin/mailman/listinfo/rabbitmq-discuss" target="_blank">https://lists.rabbitmq.com/<u></u>cgi-bin/mailman/listinfo/<u></u>rabbitmq-discuss</a><br>
</blockquote></div><br></div>