<div dir="ltr"><br><br><div class="gmail_quote">On Sun, Sep 7, 2008 at 7:24 PM, Ben Hood <span dir="ltr"><<a href="mailto:0x6e6562@gmail.com">0x6e6562@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Edwin,<br>
<br>
On Sun, Sep 7, 2008 at 11:07 PM, Edwin Fine<br>
<div class="Ih2E3d"><<a href="mailto:rabbitmq-discuss_efine@usa.net">rabbitmq-discuss_efine@usa.net</a>> wrote:<br>
</div><div class="Ih2E3d">> Maybe we can meet halfway. I didn't really want to get into rearchitecting<br>
> the RabbitMQ module structure (well, I wish I could, but I don't have time.<br>
> The mortgage payment beckons and all that incidental stuff).<br>
<br>
</div>Sure. I don't think myself or Matthias thought that you would be able<br>
to go this far, because it is difficult enough for ourselves to do<br>
this.<br>
</blockquote><div><br>Ok.<br> <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
The main thing for us is that there is some active participation in<br>
the community which provides feedback about what is needed.<br>
</blockquote><div><br>Well, since you asked ;-) ... My understanding is that OTP standards are for the .app file to have the same name as the application behaviour callback and the directory in which it is situated. For example, the OTP compiler application is in the compiler directory, and under ebin, there is compiler.app, and under src there is compiler.erl.<br>
<br>With RabbitMQ, the app config file is named rabbit.app, the app itself is rabbit.erl, but the directory is named rabbitmq_server. This is inconsistent. Now before you call me nitpicky, there is a practical issue behind this. The client that is written uses things like -include_lib("rabbitmq_server/include/rabbit.hrl"). This forces the server code to stay in a directory named rabbitmq_server, because this is what allows the includes to work via code:lib_dir(). The problem is that because the app is named rabbit, automated dependency tools like Sinan have trouble with the inconsistency.<br>
<br>Could you either rename the app to rabbitmq_server, or change all references (and the dir name) to rabbit?<br><br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
Let us know if you need any help in reaching your short term goal.<br>
<font color="#888888"></font></blockquote><div><br>Well, right now I have fudged what's needed to get going, but I the above changes would be most appreciated if at all possible.<br><br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<font color="#888888"><br>
Ben</font></blockquote><div><br>Regards,<br>Ed<br> <br></div></div><br></div>