<div dir="ltr">Hm, I made a mistake in my excitement :)<br><br><span style="font-family: courier new,monospace;"> {ok, Module} = proplists:get_value(Flavor, State#state.flavor_module),</span><br style="font-family: courier new,monospace;">
<span style="font-family: courier new,monospace;"></span><br>should be<br><br><span style="font-family: courier new,monospace;"> Module = proplists:get_value(Flavor, State#state.flavor_modules),</span><br style="font-family: courier new,monospace;">
<span style="font-family: courier new,monospace;"></span><br>where flavor_modules would contain something like [{direct, amqp_direct_driver}, {network, amqp_network_driver}, {whatever, amqp_whatever_driver}].<br><br><div class="gmail_quote">
On Sun, Sep 7, 2008 at 8:06 PM, Edwin Fine <span dir="ltr"><<a href="mailto:rabbitmq-discuss_efine@usa.net">rabbitmq-discuss_efine@usa.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div dir="ltr">Let me make a constructive suggestion. By using the configuration, we could avoid the compile-time dependency on either of those modules, and at the same time we could make amqp_connection more flexible.<br>
<br><span style="font-family: courier new,monospace;">%% Starts a new channel. Flavor is direct or network. flavor_module is set up to be</span><br style="font-family: courier new,monospace;"><span style="font-family: courier new,monospace;">%% one of amqp_direct_driver or amqp_network_driver (or, some other driver - e.g. future amqp_wmq_driver)</span><br style="font-family: courier new,monospace;">
<span style="font-family: courier new,monospace;">handle_call({Flavor, ChannelNumber, OutOfBand}, From, State) -></span><br style="font-family: courier new,monospace;"><span style="font-family: courier new,monospace;"> {ok, Module} = proplists:get_value(Flavor, State#state.flavor_module),</span><br style="font-family: courier new,monospace;">
<span style="font-family: courier new,monospace;"> handle_start({ChannelNumber, OutOfBand},</span><br style="font-family: courier new,monospace;"><span style="font-family: courier new,monospace;"> fun Module:open_channel/3,</span><br style="font-family: courier new,monospace;">
<span style="font-family: courier new,monospace;"> fun Module:close_channel/1,</span><br style="font-family: courier new,monospace;"><span style="font-family: courier new,monospace;"> fun Module:do/2,</span><br style="font-family: courier new,monospace;">
<span style="font-family: courier new,monospace;"> fun Module:do/3,</span><br style="font-family: courier new,monospace;"><span style="font-family: courier new,monospace;"> State);</span><br>
<br>What do you think?<br><br>Regards,<br>Edwin<br></div>
</blockquote></div><br></div>