I wrote:<br><br>"Please understand that all the code I have submitted (other than
amqp_channel) is a pure hack to try to expose and duplicate the errors!".<br><br>That should have read, "other than rbmq_admin.erl" - the module that I wrote to do admin tasks, which is only a semi-hack ;-)<br>
<br>Ed<br><br><div class="gmail_quote">On Fri, May 9, 2008 at 9:30 AM, Edwin Fine <<a href="mailto:rabbitmq-discuss_efine@usa.net">rabbitmq-discuss_efine@usa.net</a>> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Ben,<div class="Ih2E3d"><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div><div><div><br><div>In your patch, you also added an extra method to handle a spurious consume_ok message;</div>
<div><br></div><div><div>%% Edwin Fine bugfix: This is actually being called wrong from somewhere,</div><div>%% but this will fix it.</div><div>handle_method({'basic.consume_ok', ConsumerTag}, State) -></div><div>
io:format("[~p] Got bad handle_method call!~n", [self()]),</div><div> handle_method(#'basic.consume_ok'{consumer_tag = ConsumerTag}, State);</div></div><div><br></div><div>This method is preceded in the code by the following function:</div>
<div><br></div><div><div>handle_method(BasicConsumeOk = #'basic.consume_ok'{consumer_tag = ConsumerTag},</div><div> State = #channel_state{pending_consumer = Consumer}) -></div><div> Consumer ! BasicConsumeOk,</div>
<div> NewState = register_consumer(ConsumerTag, Consumer, State),</div><div> {noreply, NewState2} = rpc_bottom_half(BasicConsumeOk, NewState),</div><div> {noreply, NewState2#channel_state{pending_consumer = <<>>} };</div>
<div><br></div><div>So I not quite sure why that didn't match first because #'basic.consume_ok'{consumer_tag = ConsumerTag} should match against {'basic.consume_ok', ConsumerTag} and #channel_state{pending_consumer = Consumer} should match even if the pending_consumer was not defined.</div>
</div></div></div></div></blockquote><div> </div></div><div class="Ih2E3d">Actually, I was
in the middle of trying to get that right, and it was late, so I would
ignore that comment (and the code) completely. In fact I have removed
it from the most recent code. I was trying to get rid of the error that
I saw in the stack trace of the amqp_channel, namely<br>
<br></div><div class="Ih2E3d"><span style="font-family: courier new,monospace;">** Reason for termination == </span><br style="font-family: courier new,monospace;"><span style="font-family: courier new,monospace;">** {badarg,[{amqp_channel,handle_method,2},</span><br style="font-family: courier new,monospace;">
<span style="font-family: courier new,monospace;"> {gen_server,handle_msg,5},</span><br style="font-family: courier new,monospace;"><span style="font-family: courier new,monospace;"> {proc_lib,init_p,5}]}</span><br style="font-family: courier new,monospace;">
<br></div><div class="Ih2E3d">Now that I am doing the basic.consume in the process that starts the consumers, the above issue does not occur.<br>Thanks
for all your help. In the meantime, until you have a more elegant
bugfix (to the rabbit_writer proliferation) than my hack, I will just
continue to use my modified Erlang client.<br>
<br>Ben, you also wrote:<br></div><div><div class="Ih2E3d"><br>>>> That's a good point.
I think the cleanup code should go into the gen_server terminate
callback to keep it one place.<br><br></div><div class="Ih2E3d">Funny thing, that - I *did* put
the cleanup code into the terminate, but it did not seem to be called.
It was only when I put it directly before the {stop, xxx} returns that
it finally got called. Again, this may have just been late night
syndrome, but I had extensive print statements and could clearly see
that it was not happening. At that time all I wanted was to get it to
work. Please understand that all the code I have submitted (other than
amqp_channel) is a pure hack to try to expose and duplicate the errors!<br>
<br></div></div>Thanks again.<br>Regards,<br>Ed<br>
</blockquote></div><br>