[rabbitmq-discuss] Pika connection negotiation behavior

[Gavin M. Roy]

So for the point of clarity, this is the behavior of the Java, .net and
erlang client libraries -- is it the proper behavior? Should it be changed?

The documentation for RabbitMQ's server configuration does not specify that
this is (can be for some clients) the max value.

I'm inclined to change it in pika due to the non-documented and
non-specified behavior.

Gavin


On Fri, Mar 15, 2013 at 3:48 AM, Simon MacMullen <simon at rabbitmq.com> wrote:

> Well, the max(client, server) behaviour is also what our clients do so the
> precedent is there. But ultimately the server will accept whatever the
> client asks for.
>
> Cheers, Simon
>
>
> On 15/03/13 06:03, Gavin M. Roy wrote:
>
>> In Pika, currently and pre-dating my involvement, when tuning the
>> connection, it uses the /*minimum*/ value above 0 that either the server
>>
>> or client provides for the heartbeat interval:
>>
>> https://github.com/pika/pika/**blob/v0.5/pika/connection.py#**L359<https://github.com/pika/pika/blob/v0.5/pika/connection.py#L359>
>> https://github.com/pika/pika/**blob/v0.5/pika/connection.py#**L411<https://github.com/pika/pika/blob/v0.5/pika/connection.py#L411>
>>
>> Since introducing a heartbeat interval sent by the server of 600, this
>> has set a */maximum/* heartbeat interval of 600 regardless of what the
>>
>> client sets upon creation.
>>
>> In reading the 0.9.1 spec, I did not see anything dictating any behavior
>> of this sort for heartbeat interval negotiation.
>>
>> I'm inclined to allow the client to always overwrite the server, but
>> since this behavior both pre-dates my involvement and is clearly
>> intentional, I wanted to get some feedback before making the change.
>>
>> I currently have an open ticket tied to this that I would like to
>> resolve before releasing 0.9.10: https://github.com/pika/pika/**
>> issues/303 <https://github.com/pika/pika/issues/303>
>>
>> So, any thoughts?
>>
>> Gavin
>>
>>
>>
>> ______________________________**_________________
>> rabbitmq-discuss mailing list
>> rabbitmq-discuss at lists.**rabbitmq.com<rabbitmq-discuss at lists.rabbitmq.com>
>> https://lists.rabbitmq.com/**cgi-bin/mailman/listinfo/**rabbitmq-discuss<https://lists.rabbitmq.com/cgi-bin/mailman/listinfo/rabbitmq-discuss>
>>
>>
>
> --
> Simon MacMullen
> RabbitMQ, VMware
>



-- 

Gavin M. Roy
Chief Technology Officer

 <http://www.meetme.com/>
100 Union Square Drive
New Hope, PA 18938
p. +1.215.862.1162 x263
f. +1.215.862.0465

<https://www.facebook.com/pages/MeetMe/21931227129>
<https://twitter.com/meetme>
    <http://www.youtube.com/user/MeetMeVideos>

The public market leader in social discovery. (NYSE MKT: MEET)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rabbitmq.com/pipermail/rabbitmq-discuss/attachments/20130315/fd62ddad/attachment.htm>