[rabbitmq-discuss] amqp_client upgrade bug

[Jon Brisbin]

Looks like the rebar fork needs updating too. I'll do that ASAP.

FWIW- the terminate function is right above that in the code and it does not require {ok, State}, just State. Maybe a cut-and-paste error?

Anyhoo...will make the change shortly.

Sent from my iPad

On Apr 27, 2012, at 10:30 AM, Tony Garnock-Jones <tonygarnockjones+rabbitmq at gmail.com> wrote:

> Wow, thank you for noticing that. I see that the bug you report is extremely widespread. I wonder where it came from? I've updated all the libraries I maintain that suffer from this problem.
> 
> Thanks again!
> 
> Regards,
>   Tony
> 
> On 27 April 2012 10:55, Ivan Dyachkov <ivan.dyachkoff at gmail.com> wrote:
> Hi guys,
> 
> this is really weird:
> 
> src/amqp_channel.erl:
>    469 code_change(_OldVsn, State, _Extra) ->
>    470     State.
> 
> when it must return {ok, State}. So when we try to upgrade node running amqp_client, upgrade fails.
> Other modules implementing gen_server[2] behavior have the same issue.
> 
> /Ivan
> 
> _______________________________________________
> rabbitmq-discuss mailing list
> rabbitmq-discuss at lists.rabbitmq.com
> https://lists.rabbitmq.com/cgi-bin/mailman/listinfo/rabbitmq-discuss
> 
> 
> 
> 
> -- 
> Tony Garnock-Jones
> tonygarnockjones at gmail.com
> http://homepages.kcbbs.gen.nz/tonyg/
> _______________________________________________
> rabbitmq-discuss mailing list
> rabbitmq-discuss at lists.rabbitmq.com
> https://lists.rabbitmq.com/cgi-bin/mailman/listinfo/rabbitmq-discuss
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rabbitmq.com/pipermail/rabbitmq-discuss/attachments/20120427/9153b811/attachment.htm>